paint loses text if text is last item added

[dsd]

Joyride 1520, paint version 15

I can reproducibly make Paint lose text that was added to a drawing:

• open Paint,
• draw a line or two,
• click on the text tool, click somewhere on the image, type some text,
• click the "Activity" tab,
• click the "Stop" button in top right,
• go into Journal, resume Paint activity.

At this point the text has disappeared.

[brian]

Confirmed with Paint 23, build 767.

[Quozl]

Tested on 10.1.2 with Paint-27, this is still a data loss problem.

Ishan Bansal and Anubhav Aggarwal of SEETA appear to be working toward a fix to this. See for example http://patchwork.sugarlabs.org/patch/401/

From analysis of the code it seems the normal method to terminate a text entry in progress is to click in the drawing area.

The solution that I desire to this ticket is:

• if a text entry is in progress, and the activity is stopped using either the "Stop" button or Control/Q, the text entry should be terminated as if the user had clicked in the drawing area, and then the activity should be stopped.
• if a text entry is in progress, and the activity instance is saved using the "Keep" button, the text entry should be terminated as if the user had clicked in the drawing area, then the activity instance should be saved, then the text entry should return to being in progress.

Perhaps the last requirement in italics is too hard and could be omitted.

[godiard]

I think will be more complicate enable the proposed to the Keep button.

[godiard]

I think it will be difficult to enable the operation described to the Keep button.

[Quozl]

It might be done by copying the drawing area, terminating the text in that copy, and writing to the journal from the copy.

[godiard]

Change commited http://git.sugarlabs.org/projects/paint/repos/mainline/commits/c8ddf32147fb582850f64e8da87cc3d4a2f4193d

[godiard]

Will be in 353.