Ticket #6257 (new defect)

Opened 7 years ago

Last modified 6 years ago

Palette has a visible menu because of invisible items

Reported by: benzea Owned by: marco
Priority: normal Milestone: 9.1.0-cancelled
Component: sugar Version:
Keywords: Cc: Edipser
Action Needed: never set Verified: no
Deployments affected: Blocked By:
Blocking:

Description

For the networks it happens that most of the time the "Disconnect..." menu item is invisible, but the menu is still visible. This is because the code in the palette to show the menu just checks whether there are any items.

There different ways to get past this problem:

  1. Never have any hidden content, but remove the items instead
  2. Make the palette smarter about showing the widgets

I will attach a patch that implements the second approach. Note that there are some issues with this too. The problem is if items are added to the menu, and shown later on. The code in the patch will not handle that.

I have modified the order of the add/show for the network palette because of this. Other solutions would be updating the visibilities in the palette from an high priority idle handler, or forcing the activity to call update_visibilities() on the palette.

Attachments

palette-visibility.patch (3.2 kB) - added by benzea 7 years ago.
the patch

Change History

Changed 7 years ago by benzea

the patch

Changed 7 years ago by marco

  • milestone changed from Never Assigned to Update.2

Changed 6 years ago by marco

  • keywords 8.2.0:? needs-testing added

Changed 6 years ago by marco

  • next_action set to never set
  • milestone changed from 8.2.0 (was Update.2) to 9.1.0

Changed 6 years ago by marco

  • keywords 8.2.0:? needs-testing removed
Note: See TracTickets for help on using tickets.