sugar.activity.activity.Activity.save() buggy

[homunq]

If I open without a dsobject, and creat_jobject is false, self._jobject gets set to None. But then save nonchalantly does:

self.write_file(file_path) self._owns_file = True self._jobject.file_path = file_path

without checking either write_file or self._jobject for existence.

Also, I know that metadata should be in metadata, and I'm setting the right mime_type, but it still hurts not to put the right extension on my file. I don't know what magic occurs when copying to external storage, but having the right extension seems like the Right Thing To Do to me, and SPOT/DRY be damned.

I will make a patch.

[homunq]

OK I just figured out the suggested_filename trick, so I won't do the extension part.

[homunq]

(In #4365) The current base activity class in python is buggy (see 6557) and so you must save when first opening. Making that bug a blocker of this one.

[homunq]

http://dev.laptop.org/git?p=users/homunq/sugar-toolkit;a=summary is a commit with a fix for this and 4365.

[marco]

Please post the patch for review on the list.

[marco]

Please reference the patch (possibly update it too, since a long time has passed). Thanks.