|Reported by:||homunq||Owned by:||homunq|
|Component:||sugar||Version:||Development build as of this date|
|Keywords:||Cc:||homunq, marco, tomeu|
|Deployments affected:||Action Needed:||code|
If I open without a dsobject, and creat_jobject is false, self._jobject gets set to None. But then save nonchalantly does:
self._owns_file = True
self._jobject.file_path = file_path
without checking either write_file or self._jobject for existence.
Also, I know that metadata should be in metadata, and I'm setting the right mime_type, but it still hurts not to put the right extension on my file. I don't know what magic occurs when copying to external storage, but having the right extension seems like the Right Thing To Do to me, and SPOT/DRY be damned.
I will make a patch.
Change History (8)
comment:5 Changed 7 years ago by marco
- Keywords 8.2.0:? added; review? removed
- Milestone changed from Never Assigned to 8.2.0 (was Update.2)
comment:6 Changed 7 years ago by marco
- Action Needed set to review
- Keywords r? added; 8.2.0:? removed