Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6671 closed defect (fixed)

Allow countries to customize activity ordering.

Reported by: cscott Owned by: marco
Priority: blocker Milestone: Update.1
Component: sugar Version:
Keywords: release? Cc: mstone, walter
Blocked By: Blocking:
Deployments affected: Action Needed:
Verified: no

Description

The attached patch to activitytray.py allows countries to customize the order in which activities show up in the build by creating an /home/olpc/Activities/.defaults file. This requires no changes to the customization key.

This is a feature requested by our deployment countries (Peru, Mexico) for update.1. The patch is small, and even in the worst case should not cause sugar to fail (we'll just display activities in a random order).

Attachments (1)

activitiestray.patch (1.2 KB) - added by cscott 7 years ago.
Patch to activitiestray to check a custom activity ordering file in /home/olpc/Activities.

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by cscott

Patch to activitiestray to check a custom activity ordering file in /home/olpc/Activities.

comment:1 Changed 7 years ago by cjb

  • Keywords review? added

comment:2 Changed 7 years ago by cscott

  • Summary changed from Allow countries to customization activity ordering. to Allow countries to customize activity ordering.

comment:3 Changed 7 years ago by mstone

The patch looks like a conservative extension of the existing functionality and I think we're fine using it as is (assuming it works). However, from the broader stability standpoint, do we really want Sugar to blow up if it can't find any readable activity.defaults files?

comment:4 Changed 7 years ago by cscott

I was just extending the current behavior. But one could easily wrap another try/except block around the second 'read_one' if you wanted to protect against poor builds.

comment:5 Changed 7 years ago by marco

Checked in with some modifications. It will go in next joyride.

comment:6 Changed 7 years ago by marco

I forgot to mention that this went only on the update.1 branch. Activity management is going to change heavily with the redesign and tomeu already have code which conflicts with this.

comment:7 Changed 7 years ago by erikos

Tested as working in 1758.

comment:8 Changed 7 years ago by erikos

  • Resolution set to fixed
  • Status changed from new to closed

Is working fine in Update.1(700)

comment:9 Changed 7 years ago by mstone

  • Keywords release? added; review? removed
Note: See TracTickets for help on using tickets.