Ticket #6690 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

sync_friends mangles the JIDs

Reported by: morgs Owned by: dgilmore
Priority: high Milestone: Update.1
Component: presence-service Version:
Keywords: review+ Cc: Collabora
Action Needed: Verified: yes
Deployments affected: Blocked By:
Blocking:

Description

Looking in the roster of an XO that friended someone shows that sync_friends mangled the JID and added the wrong value.

Patch attached.

Attachments

Change History

Changed 6 years ago by morgs

Changed 6 years ago by morgs

  • keywords review? added

Tested in jhbuild against my local ejabberd - that's how I could see the JIDs in the rosters.

Changed 6 years ago by daf

  • keywords review+ added; review? removed

Looks fine to me.

Changed 6 years ago by morgs

  • keywords Update.1? added

Release 0.75.4 has this change, and reverts the friending-breaking patch from #6572.

sugar-presence-service-0_75_4-1_olpc2 has built in koji for the next joyride.

Changed 6 years ago by morgs

  • cc Collabora added
  • owner changed from Collabora to ApprovalForUpdate

Tested the rpm on Update-1.700 and it does fix the problem.

This is required for Gadget (the server component for Jabber server scalable presence).

Please approve for Update.1.

Changed 6 years ago by morgs

Tested with joyride-1772, working.

Please approve for Update.1. This is required for Gadget (the server component for Jabber server scalable presence).

Changed 6 years ago by jg

  • keywords Update.1? removed
  • owner changed from ApprovalForUpdate to dgilmore
  • priority changed from normal to high
  • milestone changed from Never Assigned to Update.1

approved...

Changed 6 years ago by morgs

  • status changed from new to closed
  • verified set
  • resolution set to fixed

Works in Update.1 702.

Note: See TracTickets for help on using tickets.