Opened 7 years ago

Closed 7 years ago

#6690 closed defect (fixed)

sync_friends mangles the JIDs

Reported by: morgs Owned by: dgilmore
Priority: high Milestone: Update.1
Component: presence-service Version:
Keywords: review+ Cc: Collabora
Blocked By: Blocking:
Deployments affected: Action Needed:
Verified: yes

Description

Looking in the roster of an XO that friended someone shows that sync_friends mangled the JID and added the wrong value.

Patch attached.

Attachments (1)

0001-6690-Fix-sync_friends-mangling-the-JIDs.patch (1.1 KB) - added by morgs 7 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by morgs

  • Keywords review? added

Tested in jhbuild against my local ejabberd - that's how I could see the JIDs in the rosters.

comment:2 Changed 7 years ago by daf

  • Keywords review+ added; review? removed

Looks fine to me.

comment:3 Changed 7 years ago by morgs

  • Keywords Update.1? added

Release 0.75.4 has this change, and reverts the friending-breaking patch from #6572.

sugar-presence-service-0_75_4-1_olpc2 has built in koji for the next joyride.

comment:4 Changed 7 years ago by morgs

  • Cc Collabora added
  • Owner changed from Collabora to ApprovalForUpdate

Tested the rpm on Update-1.700 and it does fix the problem.

This is required for Gadget (the server component for Jabber server scalable presence).

Please approve for Update.1.

comment:5 Changed 7 years ago by morgs

Tested with joyride-1772, working.

Please approve for Update.1. This is required for Gadget (the server component for Jabber server scalable presence).

comment:6 Changed 7 years ago by jg

  • Keywords Update.1? removed
  • Milestone changed from Never Assigned to Update.1
  • Owner changed from ApprovalForUpdate to dgilmore
  • Priority changed from normal to high

approved...

comment:7 Changed 7 years ago by morgs

  • Resolution set to fixed
  • Status changed from new to closed
  • Verified set

Works in Update.1 702.

Note: See TracTickets for help on using tickets.