Opened 7 years ago

Closed 4 years ago

#6826 closed defect (fixed)

Can't upload images with browse on blogger.com

Reported by: epastorino Owned by: erikos
Priority: high Milestone: 8.2.0 (was Update.2)
Component: browse-activity Version: Development build as of this date
Keywords: Browse-94:+ joyride-2204:+ Cc: Eben, holt, akonstam@…, epastorino, greg@…
Blocked By: Blocking:
Deployments affected: Action Needed: qa signoff
Verified: no

Description

We've found a bug here in Uruguay in Browse activity. Kids can't upload images to their blogs at www.blogger.com or send mails using their accounts at www.adinet.com.uy. Both sites (and plenty more) use javascript for its user interface, but last versions of Web activity won't show some buttons on those sites. This worked on build 385, now we're testing build 703 with Browse activity version 86, but we've seen this behaviour since build 642 at least.
I'll post more sites when I find them.

Attachments (1)

0001-6826_upload_images_with_blogger.patch (1.7 KB) - added by erikos 6 years ago.
add a gtk window for popups to webview instead of openening in the parent window

Download all attachments as: .zip

Change History (15)

comment:1 Changed 7 years ago by holt

  • Cc holt added

comment:2 Changed 7 years ago by akonstam

  • Cc akonstam@… added

Greg Smith and I have been working on this problem. I find on the XO it is more complicated than described by the people in Urguay. I am using build 656 and on my XO the following happens:
When I try to post a new page , first, I cannot add text to the space set aside for the content of the posting. Then when I try to load an image it says it is being loaded and click on the DONE button to have it appear. There is no DONE button to click on.

Greg contacted someone from google (we are using the google blogger site www.blogger.com) whose nane and address is: Tyrone Nicholas <tnicholas@…>. He said that one could close the window and the image would be loaded but on the XO it is not clear that you can close the uaydow.

Now using a fedora 7 machine as a test bed this process works in the browsers firefox and seamonkey but when you use the browseer Konqueror the process fials in a similar way to the XO.

I think it is a browser problem and who ever is the mainatainer of the Browser on the XO should look at this problem and maybe communicate with this man at google.

It looks to me that the people in Urgway ar eeusing a different build which might be a factot in our results being different,

comment:3 Changed 7 years ago by mstone

  • Cc epastorino added
  • Owner changed from epastorino to erikos

comment:4 Changed 7 years ago by holt

More of Greg Smith's details here within RT Ticket# 9174, for Support Gang Volunteers (http://lists.laptop.org/listinfo/support-gang) :

http://rt.laptop.org/Ticket/Display.html?id=9174

comment:5 Changed 6 years ago by erikos

  • Summary changed from JavaScript not fully supported in Browse activity to Can't upload images with browse on blogger.com

What we know so far:

  • I updated to xulrunner beta5 but the behavior is the same for blogger.com. You cannot upload an image.
  • with firefox3 beta 5 browser the uploading of the image works on the site blogger.com
  • I verified that it has nothing to do with rainbow by switching it off.
  • the upload opens a new window; we open in the browser on the XO (wanted) popup windows in the same window; i replaced this with opening a gtk.dialog window but the same problem occurs
  • hitting the 'done' button does not work and as well the thumbnail of the image is not displayed

comment:6 Changed 6 years ago by gregorio

  • Cc gregmsmi@… added

Changed 6 years ago by erikos

add a gtk window for popups to webview instead of openening in the parent window

comment:7 follow-up: Changed 6 years ago by erikos

  • Action Needed set to communicate
  • Cc Eben added

The attached patch works fine for #6825 (the email webfrontend adinet.com.uy) and the blogger.com issue for uploading images which is described in this ticket.

The patch works as follows:

  • when we are asked to provide a new window we are opening now a gtk.window and add the content into it (before we opened popups in the same window)
  • we make this transient to the parent window
  • we decorate it (close button on top etc)

The last point I am not sure about yet. We can provide our own close button - but I have not found out (yet) to make the window movable then. In the case of the popup we might want to be able to move the window since we want to look at the content below - don't know - eben has an opinion about that i am sure.

Testcase:
dev.laptop.org/~erikos/wanted.html

This allows as well to test the case when another window is opened by the popup (e.g. our objectchoser to upload a file)

I would be interested to know as well if this model breaks for other sites? Other testcases welcome.

comment:8 in reply to: ↑ 7 Changed 6 years ago by epastorino

Replying to erikos:

The attached patch works fine for #6825 (the email webfrontend adinet.com.uy) and the blogger.com issue for uploading images which is described in this ticket.

The patch works as follows:

  • when we are asked to provide a new window we are opening now a gtk.window and add the content into it (before we opened popups in the same window)
  • we make this transient to the parent window
  • we decorate it (close button on top etc)

The last point I am not sure about yet. We can provide our own close button - but I have not found out (yet) to make the window movable then. In the case of the popup we might want to be able to move the window since we want to look at the content below - don't know - eben has an opinion about that i am sure.

Testcase:
dev.laptop.org/~erikos/wanted.html

This allows as well to test the case when another window is opened by the popup (e.g. our objectchoser to upload a file)

I would be interested to know as well if this model breaks for other sites? Other testcases welcome.

Just tried the patch. Now we can upload images, but after you do that, the "Finish" button doesn't close the window. Anyway, that's not critical because the image has been uploaded by then.

The objectchoser also works fine, the popup can open other windows.

comment:9 Changed 6 years ago by erikos

Thanks very much for testing! Yeah the finish button does not close that is right. The same happens for the email web frontend. I will have a look if I can figure that one out as well.

comment:10 Changed 6 years ago by marco

  • Action Needed changed from communicate to test in build

comment:11 Changed 6 years ago by erikos

  • Action Needed changed from test in build to qa signoff
  • Keywords Browse-94:+ joyride-2204:+ added; javascript browse activity bug removed

Tested as working fine with Browse-94 and joyride >= 2204

comment:12 Changed 6 years ago by erikos

|TestCase|

go to blogger.com and create a new blog post. Upload an image to that post.

comment:13 Changed 6 years ago by holt

  • Cc greg@… added; gregmsmi@… removed

comment:14 Changed 4 years ago by godiard

  • Resolution set to fixed
  • Status changed from new to closed

Tested in Browse 108

it's working ok now

Note: See TracTickets for help on using tickets.