sugar-install-bundle dies when no parameters are passes.

[ffm]

Downstream bug (with logs and such): Launchpad.net

This issue occurred because the command was called with no parameters.

Ideally, it should provide a nice usage message, that explains what the command does.

[ffm]

Traceback:

Traceback (most recent call last):

File "/usr/bin/sugar-install-bundle", line 9, in <module>

bundle = ActivityBundle(sys.argv[1])

IndexError: list index out of range

[ffm]

git-diff of the proposed change

[erikos]

I actually would handle it like this - since only one argumant is supported:

+def cmd_help():
+    print 'Usage: sugar-install-bundle [ bundlename ] \n\n\
+    Install an activity bundle (.xo). \n'
+
+if len(sys.argv) != 2:
+    cmd_help()
+    sys.exit(2)
+
 bundle = ActivityBundle(sys.argv[1])
 bundle.install()

[ffm]

Replying to erikos:

I actually would handle it like this - since only one argumant is supported:

Sure, that'd work well too.

[erikos]

I pushed the fix to sugar git master, thanks for spotting and patch.