Ticket #7427 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Downloads broken in Browse

Reported by: tomeu Owned by: erikos
Priority: normal Milestone: 8.2.0 (was Update.2)
Component: browse-activity Version: Development source as of this date
Keywords: Browse-92:+ Cc:
Action Needed: finalize Verified: no
Deployments affected: Blocked By:
Blocking:

Description

Because in the last mozilla update, one interface changed:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/uriloader/exthandler&command=DIFF_FRAMESET&file=nsIHelperAppLauncherDialog.idl&rev2=1.11&rev1=1.10

This seems to fix it:

diff --git a/downloadmanager.py b/downloadmanager.py
index a9cd960..292e1a8 100644
--- a/downloadmanager.py
+++ b/downloadmanager.py
@@ -79,7 +79,8 @@ class DownloadManager:
     _com_interfaces_ = interfaces.nsIHelperAppLauncherDialog
 
     def promptForSaveToFile(self, launcher, window_context,
-                            default_file, suggested_file_extension):
+                            default_file, suggested_file_extension,
+                            force_prompt):
         file_class = components.classes["@mozilla.org/file/local;1"]
         dest_file = file_class.createInstance(interfaces.nsILocalFile)

Change History

Changed 6 years ago by erikos

  • next_action changed from code to add to build

Good catch. I made it force_prompt=False to not brake with older versions and pushed it to git.

Changed 6 years ago by erikos

|TestCase|

Download a file with Browse on a system where xulrunner is >= 1.9-1

Changed 6 years ago by erikos

  • keywords Web-92 added

Changed 6 years ago by dsd

confirmed that this works in Browse-92, thanks!

Changed 6 years ago by erikos

  • keywords Browse-92:+ added; Web-92 removed
  • next_action changed from add to build to finalize

Changed 6 years ago by gregorio

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.