Downloads broken in Browse

[tomeu]

Because in the last mozilla update, one interface changed:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/uriloader/exthandler&command=DIFF_FRAMESET&file=nsIHelperAppLauncherDialog.idl&rev2=1.11&rev1=1.10

This seems to fix it:

diff --git a/downloadmanager.py b/downloadmanager.py
index a9cd960..292e1a8 100644
--- a/downloadmanager.py
+++ b/downloadmanager.py
@@ -79,7 +79,8 @@ class DownloadManager:
     _com_interfaces_ = interfaces.nsIHelperAppLauncherDialog
 
     def promptForSaveToFile(self, launcher, window_context,
-                            default_file, suggested_file_extension):
+                            default_file, suggested_file_extension,
+                            force_prompt):
         file_class = components.classes["@mozilla.org/file/local;1"]
         dest_file = file_class.createInstance(interfaces.nsILocalFile)

[erikos]

Good catch. I made it force_prompt=False to not brake with older versions and pushed it to git.

[erikos]

|TestCase|

Download a file with Browse on a system where xulrunner is >= 1.9-1

[dsd]

confirmed that this works in Browse-92, thanks!