Opened 6 years ago

Closed 6 years ago

#7427 closed defect (fixed)

Downloads broken in Browse

Reported by: tomeu Owned by: erikos
Priority: normal Milestone: 8.2.0 (was Update.2)
Component: browse-activity Version: Development source as of this date
Keywords: Browse-92:+ Cc:
Blocked By: Blocking:
Deployments affected: Action Needed: finalize
Verified: no

Description

Because in the last mozilla update, one interface changed:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/uriloader/exthandler&command=DIFF_FRAMESET&file=nsIHelperAppLauncherDialog.idl&rev2=1.11&rev1=1.10

This seems to fix it:

diff --git a/downloadmanager.py b/downloadmanager.py
index a9cd960..292e1a8 100644
--- a/downloadmanager.py
+++ b/downloadmanager.py
@@ -79,7 +79,8 @@ class DownloadManager:
     _com_interfaces_ = interfaces.nsIHelperAppLauncherDialog
 
     def promptForSaveToFile(self, launcher, window_context,
-                            default_file, suggested_file_extension):
+                            default_file, suggested_file_extension,
+                            force_prompt):
         file_class = components.classes["@mozilla.org/file/local;1"]
         dest_file = file_class.createInstance(interfaces.nsILocalFile)

Change History (6)

comment:1 Changed 6 years ago by erikos

  • Action Needed changed from code to add to build

Good catch. I made it force_prompt=False to not brake with older versions and pushed it to git.

comment:2 Changed 6 years ago by erikos

|TestCase|

Download a file with Browse on a system where xulrunner is >= 1.9-1

comment:3 Changed 6 years ago by erikos

  • Keywords Web-92 added

comment:4 Changed 6 years ago by dsd

confirmed that this works in Browse-92, thanks!

comment:5 Changed 6 years ago by erikos

  • Action Needed changed from add to build to finalize
  • Keywords Browse-92:+ added; Web-92 removed

comment:6 Changed 6 years ago by gregorio

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.