Ticket #7494 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Updates to Browse-92 fail.

Reported by: cscott Owned by: homunq
Priority: blocker Milestone: 8.2.0 (was Update.2)
Component: sugar Version: Development build as of this date
Keywords: joyride-2240:+ sugar-toolkit-0.81.8:+ Cc: homunq, marco, tomeu
Action Needed: qa signoff Verified: no
Deployments affected: Blocked By:
Blocking: #4951, #6583

Description

The activity directory name inside the Browse-92 activitiy bundle has changed from that of Web-90, although they share the same bundle_id. This confuses the sugar.bundle.activitybundle.ActivityBundle.uninstall() code, invoked on upgrade, since it assumes the old bundle is at the same activity path as the new bundle.

Tested in joyride-2153.

Attachments

Change History

Changed 5 years ago by cscott

  • blocking 6583 added

(In #6583) Ergh, this seems to have been done, causing #7494.

Changed 5 years ago by cscott

Related work on sugar.bundle.activitybundle: #7220.

Changed 5 years ago by homunq

  • owner changed from marco to homunq
  • status changed from new to assigned
  • next_action changed from never set to code

accepting this.

Changed 5 years ago by homunq

  • cc homunq added

Changed 5 years ago by homunq

Changed 5 years ago by homunq

  • keywords r? added
  • next_action changed from code to review

The simple one-line patch fixes this issue, although I would be happier to fix the related #7575 as well.

Changed 5 years ago by marco

  • keywords r+ added; r? removed

Thanks, code looks good. Please fixup your user/email with something like:

$ git config --global user.name "FirstName LastName" $ git config --global user.email "user@…"

Then resubmit the patch and I'll check it in.

Changed 5 years ago by homunq

Changed 5 years ago by homunq

Changed 5 years ago by cscott

  • blocking 4951 added

Changed 5 years ago by homunq

  • next_action changed from review to package

Changed 5 years ago by erikos

  • cc marco, tomeu added

The patch looks good - however it only works when we call bundle.upgrade() or uninstall the bundle before we install it. sugar-install-bundle for example will therefore fail in this case since it only calls bundle.install()

For a broader discussion on the installation issue see #7713

Changed 5 years ago by mstone

  • keywords 8.2.0:? added
  • priority changed from high to blocker

Please get this merged and packaged so that we can test it!

Changed 5 years ago by cscott

I can't find evidence that this has been committed to sugar git yet.

Changed 5 years ago by marco

Here it is:

http://dev.laptop.org/git?p=sugar-toolkit;a=commit;h=62af4ae9bbbbce808e9f5500eebc00a799868a3c

It's in 0.81.8.

Changed 5 years ago by cscott

  • next_action changed from package to test in build

Thanks. I thought it had made it in, and I was surprised to not be able to find it. Turns out I was looking in the wrong place. ;-)

Ok, the fix is in the build, please test!

Changed 5 years ago by erikos

  • keywords joyride-2240:+ sugar-toolkit-0.81.8:+ added; r+ 8.2.0:? removed
  • next_action changed from test in build to qa signoff

Works - installed version Web-91 and then updated using the control-panel to Browse-95

Changed 5 years ago by cscott

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.