Opened 6 years ago

Closed 6 years ago

#7494 closed defect (fixed)

Updates to Browse-92 fail.

Reported by: cscott Owned by: homunq
Priority: blocker Milestone: 8.2.0 (was Update.2)
Component: sugar Version: Development build as of this date
Keywords: joyride-2240:+ sugar-toolkit-0.81.8:+ Cc: homunq, marco, tomeu
Blocked By: Blocking: #4951, #6583
Deployments affected: Action Needed: qa signoff
Verified: no

Description

The activity directory name inside the Browse-92 activitiy bundle has changed from that of Web-90, although they share the same bundle_id. This confuses the sugar.bundle.activitybundle.ActivityBundle.uninstall() code, invoked on upgrade, since it assumes the old bundle is at the same activity path as the new bundle.

Tested in joyride-2153.

Change History (18)

comment:1 Changed 6 years ago by cscott

  • Blocking 6583 added

(In #6583) Ergh, this seems to have been done, causing #7494.

comment:2 Changed 6 years ago by cscott

Related work on sugar.bundle.activitybundle: #7220.

comment:3 Changed 6 years ago by homunq

  • Action Needed changed from never set to code
  • Owner changed from marco to homunq
  • Status changed from new to assigned

accepting this.

comment:4 Changed 6 years ago by homunq

  • Cc homunq added

comment:5 Changed 6 years ago by homunq

  • Action Needed changed from code to review
  • Keywords r? added

The simple one-line patch fixes this issue, although I would be happier to fix the related #7575 as well.

comment:6 Changed 6 years ago by marco

  • Keywords r+ added; r? removed

Thanks, code looks good. Please fixup your user/email with something like:

$ git config --global user.name "FirstName LastName"
$ git config --global user.email "user@…"

Then resubmit the patch and I'll check it in.

comment:7 Changed 6 years ago by cscott

  • Blocking 4951 added

comment:8 Changed 6 years ago by homunq

  • Action Needed changed from review to package

comment:9 Changed 6 years ago by erikos

  • Cc marco tomeu added

The patch looks good - however it only works when we call bundle.upgrade() or uninstall the bundle before we install it. sugar-install-bundle for example will therefore fail in this case since it only calls bundle.install()

For a broader discussion on the installation issue see #7713

comment:10 Changed 6 years ago by mstone

  • Keywords 8.2.0:? added
  • Priority changed from high to blocker

Please get this merged and packaged so that we can test it!

comment:11 Changed 6 years ago by cscott

I can't find evidence that this has been committed to sugar git yet.

comment:13 Changed 6 years ago by cscott

  • Action Needed changed from package to test in build

Thanks. I thought it had made it in, and I was surprised to not be able to find it. Turns out I was looking in the wrong place. ;-)

Ok, the fix is in the build, please test!

comment:14 Changed 6 years ago by erikos

  • Action Needed changed from test in build to qa signoff
  • Keywords joyride-2240:+ sugar-toolkit-0.81.8:+ added; r+ 8.2.0:? removed

Works - installed version Web-91 and then updated using the control-panel to Browse-95

comment:15 Changed 6 years ago by cscott

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.