Opened 6 years ago

Closed 6 years ago

#7506 closed defect (fixed)

Browse not installing .xol bundles

Reported by: Charlie Owned by: marco
Priority: normal Milestone:
Component: sugar Version:
Keywords: 8.2.0:? joyride-2146:- r+ joyride-2201:+ Cc: joe, kimquirk, dsd
Blocked By: Blocking:
Deployments affected: Action Needed: package
Verified: no

Description

As mentioned here, Browse-92 can download .xol files but does not install them into /home/olpc/Library. This issue was previously masked by #7427. (If one can't download, how can one install?)

In addition, attempting to open .xol files from the Journal (either from a USB stick or after downloading through Browse) has no visible effect -- nothing is added to /home/olpc/Library, and there is no response from Journal or Sugar indicating that something may have changed. The bundle does not appear in Browse even after rebooting the XO.

Attachments (4)

org.laptop.JournalActivity-1.log (14.5 KB) - added by Charlie 6 years ago.
datastore.log (11.2 KB) - added by Charlie 6 years ago.
org.laptop.WebActivity-1.log (9.7 KB) - added by Charlie 6 years ago.
contentbundle.patch (851 bytes) - added by dsd 6 years ago.
patch to fix the journal contentbundle exception

Download all attachments as: .zip

Change History (14)

Changed 6 years ago by Charlie

comment:1 Changed 6 years ago by dsd

  • Keywords 8.2.0:? added

This probably isn't a browse bug but I'm not sure where it should be filed. The relevant line from the journal log is:

1216044454.290063 WARNING root: No activity can open this object, application/vnd.olpc-content.

I also got this error in my journal logs, I think it occurred immediately after the .xol download in browse completed:

1216045203.795985 ERROR dbus.connection: Exception in handler for D-Bus signal:
Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/dbus/connection.py", line 214, in maybe_handle_message
    self._handler(*args, **kwargs)
  File "/usr/share/sugar/activities/Journal.activity/journalactivity.py", line 251, in __data_store_updated_cb
    self._check_for_bundle(jobject)
  File "/usr/share/sugar/activities/Journal.activity/journalactivity.py", line 265, in _check_for_bundle
    bundle = misc.get_bundle(jobject)
  File "/usr/share/sugar/activities/Journal.activity/misc.py", line 100, in get_bundle
    return ContentBundle(jobject.file_path)
  File "/usr/lib/python2.5/site-packages/sugar/bundle/contentbundle.py", line 52, in __init__
    info_file = self._get_file('library/library.info')
AttributeError: ContentBundle instance has no attribute '_get_file'

Changed 6 years ago by Charlie

Changed 6 years ago by Charlie

comment:2 Changed 6 years ago by dsd

  • Keywords joyride-2146:- added

Changed 6 years ago by dsd

patch to fix the journal contentbundle exception

comment:3 Changed 6 years ago by dsd

  • Keywords r? added

comment:4 Changed 6 years ago by dsd

  • Action Needed changed from never set to review
  • Component changed from browse-activity to sugar
  • Owner changed from erikos to marco

comment:5 Changed 6 years ago by dsd

With that patch, libraries are successfully unpacked. The library index page regeneration is broken, separate issue, see #7523

comment:6 Changed 6 years ago by tomeu

The patch looks good to me. Please add a test case following the link below and then set the flags accordingly afterwards. Thanks!

http://wiki.sugarlabs.org/go/DevelopmentTeam/CodeReview#Patch_submission

comment:7 Changed 6 years ago by dsd

  • Keywords r+ added; r? removed

|TestCase|

comment:8 Changed 6 years ago by mstone

  • Action Needed changed from review to test in build

comment:9 Changed 6 years ago by mstone

  • Action Needed changed from test in build to package

We need a sugar package, then a build, then a test run.

comment:10 Changed 6 years ago by dsd

  • Keywords joyride-2201:+ added
  • Resolution set to fixed
  • Status changed from new to closed

This is fixed in joyride-2201

Note: See TracTickets for help on using tickets.