Opened 6 years ago

Closed 6 years ago

#7523 closed defect (fixed)

library index regeneration fails due to no XDG_DATA_DIRS

Reported by: dsd Owned by: marco
Priority: high Milestone: 8.2.0 (was Update.2)
Component: sugar Version: Development build as of this date
Keywords: 8.2.0:? r+ blocks:8.2.0 joyride-2201:+ Cc: mstone, dsd
Blocked By: Blocking:
Deployments affected: Action Needed: package
Verified: no

Description

sugar-toolkit commit 7b485120a3 resulted in XDG_DATA_DIRS being used to launch /usr/share/library-common/make_index.py.

XDG_DATA_DIRS is not set in the environment, both on 708 and joyride. Should we set it in e.g. /usr/bin/olpc-session, change sugar-toolkit, or what? i note that http://standards.freedesktop.org/basedir-spec/basedir-spec-0.5.html says:

 If $XDG_DATA_DIRS is either not set or empty, a value equal to /usr/local/share/:/usr/share/ should be used. 

Attachments (1)

0001--7523-library-regeneration-fails-as-XDG_DATA_DIRS-is.patch (1.4 KB) - added by dsd 6 years ago.
use default value if variable is not set

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by mstone

  • Cc mstone added

comment:2 Changed 6 years ago by mstone

  • Action Needed changed from never set to design
  • Keywords 8.2.0:? added
  • Priority changed from normal to high

comment:3 Changed 6 years ago by tomeu

If we are violating the spec and by complying we would be fixing this ticket, then I think we need to do what the spec says and fall back to /usr/local/share/:/usr/share/ ?

Changed 6 years ago by dsd

use default value if variable is not set

comment:4 Changed 6 years ago by dsd

  • Action Needed changed from design to review
  • Cc dsd added
  • Keywords r? added

|TestCase|

comment:5 Changed 6 years ago by tomeu

  • Action Needed changed from review to add to build
  • Keywords r+ added; r? removed

comment:6 Changed 6 years ago by dsd

  • Action Needed changed from add to build to package

Committed to sugar-toolkit git

comment:7 Changed 6 years ago by mstone

  • Keywords blocks:8.2.0 added

comment:8 Changed 6 years ago by dsd

  • Keywords joyride-2201:+ added
  • Resolution set to fixed
  • Status changed from new to closed

This is fixed in joyride-2201

Note: See TracTickets for help on using tickets.