Ticket #7523 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

library index regeneration fails due to no XDG_DATA_DIRS

Reported by: dsd Owned by: marco
Priority: high Milestone: 8.2.0 (was Update.2)
Component: sugar Version: Development build as of this date
Keywords: 8.2.0:? r+ blocks:8.2.0 joyride-2201:+ Cc: mstone, dsd
Action Needed: package Verified: no
Deployments affected: Blocked By:
Blocking:

Description

sugar-toolkit commit 7b485120a3 resulted in XDG_DATA_DIRS being used to launch /usr/share/library-common/make_index.py.

XDG_DATA_DIRS is not set in the environment, both on 708 and joyride. Should we set it in e.g. /usr/bin/olpc-session, change sugar-toolkit, or what? i note that http://standards.freedesktop.org/basedir-spec/basedir-spec-0.5.html says:

 If $XDG_DATA_DIRS is either not set or empty, a value equal to /usr/local/share/:/usr/share/ should be used. 

Attachments

0001--7523-library-regeneration-fails-as-XDG_DATA_DIRS-is.patch (1.4 kB) - added by dsd 6 years ago.
use default value if variable is not set

Change History

Changed 6 years ago by mstone

  • cc mstone added

Changed 6 years ago by mstone

  • keywords 8.2.0:? added
  • priority changed from normal to high
  • next_action changed from never set to design

Changed 6 years ago by tomeu

If we are violating the spec and by complying we would be fixing this ticket, then I think we need to do what the spec says and fall back to /usr/local/share/:/usr/share/ ?

Changed 6 years ago by dsd

use default value if variable is not set

Changed 6 years ago by dsd

  • cc dsd added
  • keywords r? added
  • next_action changed from design to review

|TestCase| * Go to this URL in browse: http://wiki.laptop.org/images/d/df/Bible-en.xol * Wait a few seconds for it to download and install * Close browse * Launch browse * On the home page, check that "NET Bible" appears under the books heading

Changed 6 years ago by tomeu

  • keywords r+ added; r? removed
  • next_action changed from review to add to build

Changed 6 years ago by dsd

  • next_action changed from add to build to package

Committed to sugar-toolkit git

Changed 6 years ago by mstone

  • keywords blocks:8.2.0 added

Changed 6 years ago by dsd

  • keywords joyride-2201:+ added
  • status changed from new to closed
  • resolution set to fixed

This is fixed in joyride-2201

Note: See TracTickets for help on using tickets.