Opened 6 years ago

Closed 5 years ago

#7633 closed defect (fixed)

Chat from jabber client doesn't work more than once per session

Reported by: morgs Owned by: joe
Priority: normal Milestone: 9.1.0-cancelled
Component: chat-activity Version: not specified
Keywords: joyride-2230:+ chat-44:+ Cc: Collabora, Eben
Blocked By: Blocking:
Deployments affected: Action Needed: qa signoff
Verified: no

Description

If you close Chat, then there is no feedback to the Jabber client that you went away. Closing and reopening the conversation in the Jabber client doesn't initiate a new invitation or connection.

Does Chat need to close the Text Channel?

Change History (12)

comment:1 Changed 6 years ago by gdesmott

I think so, yes.
By closing the channel, a new one will be created if the contact talk to you again and so it should be dispatched as a new invitation (iirc how it works in sugar).

Anyway, Chat doesn't close the channel when leaving in the muc case? If it doesn't, that's definitely a bug.

comment:2 Changed 6 years ago by morgs

  • Action Needed changed from diagnose to package

Fix in git for next release.

comment:3 Changed 6 years ago by morgs

|TestCase|

Initiate a one to one chat from a non-sugar jabber client as documented in #6298. Close Chat on the XO. Send a further message from the jabber client. A further Chat invitation should appear to launch Chat and have further discussion.

comment:4 Changed 6 years ago by morgs

  • Action Needed changed from package to test in build

comment:5 Changed 6 years ago by morgs

Fixed in Chat-44.

comment:6 Changed 6 years ago by morgs

  • Action Needed changed from test in build to qa signoff
  • Keywords joyride-2230:+ chat-44:+ added

Tested with Chat-44 on Joyride 2230.

comment:7 follow-up: Changed 6 years ago by Charlie

  • Owner changed from morgs to Charlie

Tested in Chat-45 on Joyride 2263.

I would say that this is working now, but I just to be sure before I close the ticket: the desired behavior when the XO user declines an invite from a non-XO XMPP user is to auto-decline all subsequent chat invites from that non-XO user until Sugar is restarted?

comment:8 in reply to: ↑ 7 Changed 6 years ago by morgs

  • Cc Eben added

Replying to Charlie:

Tested in Chat-45 on Joyride 2263.

I would say that this is working now, but I just to be sure before I close the ticket: the desired behavior when the XO user declines an invite from a non-XO XMPP user is to auto-decline all subsequent chat invites from that non-XO user until Sugar is restarted?

I wasn't specifically aware of it, but it sounds like a reasonable behaviour at this point.
Eben, any comments?

In the next release I'll see if I can get the invite to display the identity of the person inviting you to chat: #7869

comment:9 Changed 6 years ago by Eben

Yeah, this certainly isn't desired behavior, I'd say, but I don't think it's worth waving arms about right now. We'll need to put a bit of thought into the invitation system in general (not just from external sources) and think about whether or not we need a "block" action to prevent additional invitations from a particular identity, or if "invitation spam" can be otherwise avoided.

Having the identity seems like a requisite to any reasonable solution, so we can wait on that before resolving this issue.

comment:10 Changed 6 years ago by kimquirk

  • Milestone changed from 8.2.0 (was Update.2) to 9.1.0

If there is required for this bug, it will be done in a future release.

comment:11 Changed 6 years ago by Charlie

  • Owner changed from Charlie to joe

comment:12 Changed 5 years ago by cjl

  • Resolution set to fixed
  • Status changed from new to closed

The comments here read like this should be closed as fixed. If the separate issue raised in later comments is still current, a new ticket should be opened at bugs.sugarlabs.org (Chat development has migrated to SL from OLPC).

closing as fixed.

Note: See TracTickets for help on using tickets.