Opened 6 years ago

Closed 6 years ago

#7660 closed defect (fixed)

XO Neighborhood icon drawing & erase glitches

Reported by: garycmartin Owned by: marco
Priority: high Milestone: 8.2.0 (was Update.2)
Component: sugar Version: Development build as of this date
Keywords: r+ Cc:
Blocked By: Blocking:
Deployments affected: Action Needed: finalize
Verified: no

Description

(joyride-2212) After attaching to xochat.org jabberserver and watching some XO arrival and departure churn, the departing XO icons are not 100% erased (parts of the head left on screen). Also on closer inspection, most displayed XOs have a few pixels clipped off the top of their heads. See attached screen shot (note the pixel remnants). Not sure if shared activity icons are also affected by this, I didn't see enough of them churn.

Your own XO icon also has a slight pixel or two jump to the top left for both the Neighborhood and Group view (i.e. the XO zoom effect doesn't quite align with the final placement).

Attachments (2)

network neighborhood XO draw glitch.png (50.8 KB) - added by garycmartin 6 years ago.
0001-7660-Correctly-set-the-icon-allocation.patch (1.2 KB) - added by tomeu 6 years ago.

Download all attachments as: .zip

Change History (19)

Changed 6 years ago by garycmartin

comment:1 Changed 6 years ago by marco

  • Action Needed changed from never set to diagnose
  • Priority changed from normal to high

comment:2 Changed 6 years ago by mtd

Perhaps the second point:

Your own XO icon also has a slight pixel or two jump to the top left for both the Neighborhood and Group view (i.e. the XO zoom effect doesn't quite align with the final placement).

...can be dealt with in #7824.

comment:3 Changed 6 years ago by kimquirk

  • Milestone changed from 8.2.0 (was Update.2) to 9.1.0

Not a blocker for 8.2

comment:4 Changed 6 years ago by tomeu

  • Action Needed changed from diagnose to review
  • Keywords r? added

comment:5 Changed 6 years ago by marco

  • Keywords r+ added; r? removed

Looks fine, as long as the python bindings handle passing in floats for ints correctly.

comment:6 Changed 6 years ago by tomeu

  • Action Needed changed from review to package

comment:7 Changed 6 years ago by marco

  • Action Needed changed from package to test in build
  • Milestone changed from 9.1.0 to 8.2.0 (was Update.2)

comment:8 follow-up: Changed 6 years ago by tomeu

|TestCase|

Boot into one XO, boot into another and see the second XO appear in the neighborhood view of the first one. Shutdown the second XO, check that the icon disappears from the first XO's neighborhood view.

comment:9 in reply to: ↑ 8 Changed 6 years ago by tomeu

Replying to tomeu:

|TestCase|

Boot into one XO, boot into another and see the second XO appear in the neighborhood view of the first one. Shutdown the second XO, check that the icon disappears from the first XO's neighborhood view.

That should be, _completely_ disappears.

comment:10 Changed 6 years ago by marco

  • Action Needed changed from test in build to approve for release

comment:11 Changed 6 years ago by marco

  • Action Needed changed from approve for release to add to build

comment:12 Changed 6 years ago by cscott

  • Action Needed changed from add to build to add to release

Exact packages and versions, please. Also tag them dist-olpc3-testing.

comment:13 Changed 6 years ago by marco

sugar-0.82.2-1.fc9

comment:14 Changed 6 years ago by cscott

  • Action Needed changed from add to release to test in release

Committed to stable repo:
http://mock.laptop.org/gitweb/gitweb.cgi?p=repos;a=commitdiff;h=e0489cd6dec4b910445f489632adb44ba136c1c1

Should be in build 758 and following; please test.

comment:15 Changed 6 years ago by frances

tested in 8.2-759 and no icon image was left behind after leaving chat.

comment:16 Changed 6 years ago by garycmartin

  • Action Needed changed from test in release to finalize

Tested in 8.2-760, left running in the neighborhood view for half a day on a fairly active xochat.org jaberd server. No redraw graphic glitches seen. Working for me.

comment:17 Changed 6 years ago by gregorio

  • Resolution set to fixed
  • Status changed from new to closed

Closed with no doc needed. GS

Note: See TracTickets for help on using tickets.