Opened 6 years ago

Last modified 6 years ago

#7818 reopened defect

Load the XIM GTK+ input module conditionally

Reported by: sayamindu Owned by: mstone
Priority: high Milestone: 9.1.0-cancelled
Component: distro Version: not specified
Keywords: localization, keyboard 8.2-759:+ cjbfor9.1.0 Cc: cscott, dsd
Blocked By: Blocking:
Deployments affected: Action Needed: diagnose
Verified: no

Description

The XIM module, while partially enabling us to fix the Amharic Compose issue (#7474), seems creates problems for layouts in locales which do not have a glibc locale defined (eg: Dari, etc). We need Compose support only for Amharic right now (and also probably Khmer - which has not been tested very extensively so far), and so I propose that we load the XIM module conditionally.

It is to be noted however, that the module which is loaded by default (gtk-im-context-simple) does have support for commonly used Compose sequences (which are used in the Western world).

Attachments (1)

olpc-utils_load_xim_conditionally.patch (1002 bytes) - added by sayamindu 6 years ago.
Patch to implement the behaviour

Download all attachments as: .zip

Change History (18)

Changed 6 years ago by sayamindu

Patch to implement the behaviour

comment:1 Changed 6 years ago by sayamindu

  • Blocking 7269 added

(In #7269) The patch attached to #7818 fixes the Dari keyboard.

comment:2 Changed 6 years ago by sayamindu

  • Cc cscott added

comment:3 follow-up: Changed 6 years ago by cscott

sayamindu appears to have committed this patch to git; olpc-utils just needs rebuilding.

comment:4 in reply to: ↑ 3 Changed 6 years ago by sayamindu

  • Action Needed changed from review to package

Replying to cscott:

sayamindu appears to have committed this patch to git; olpc-utils just needs rebuilding.

That's correct. I had submitted the build task in Koji when it went down - I am waiting for Koji to come up.

comment:5 Changed 6 years ago by dsd

  • Cc dsd added

This is now in joyride. Please confirm that it works and supply a change log and test case, then move this bug into 'approve for release' state

comment:6 Changed 6 years ago by sayamindu

  • Action Needed changed from package to approve for release

It works.

|Test Case|
In a machine with an Amharic keyboard, install the build switch to the Amharic layout in sugar

Verify (in the mesh search bar) that the sequence u h produces ሁ

comment:7 Changed 6 years ago by dsd

Please also confirm that "olpc-utils-0.86-1.olpc3" is the package in question? Scott will probably ask for a changelog entry too.

comment:8 Changed 6 years ago by cscott

  • Action Needed changed from approve for release to test in release

olpc-utils-0.86-1.olpc3 will be in 758 (it was requested in 8142); please test.

comment:9 Changed 6 years ago by sayamindu

olpc-utils-0.86-1.olpc3 contains the fix.

ChangeLog:
dlo#7818: Load the XIM GTK Input Module conditionally

comment:10 Changed 6 years ago by dsd

Sayamindu, can you test this in 759? Or instruct someone else how it can be tested? This can then be moved into 'finalize' state.

comment:11 Changed 6 years ago by sayamindu

  • Action Needed changed from test in release to finalize

Works in 759.

comment:12 Changed 6 years ago by dsd

  • Keywords 8.2-759:+ added

comment:13 Changed 6 years ago by gregorio

  • Resolution set to fixed
  • Status changed from new to closed

comment:14 Changed 6 years ago by kimquirk

  • Milestone changed from 8.2.0 (was Update.2) to 8.2.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening as I am not getting the character that Sayamindu got in build 759 in the lastest, 760. Is it a regression or am I not testing this properly?

I get the character in a box FE on top and 75 below it. See #8127... the test case is the same for both and I don't think the result is correct. Moving this to 8.2.1.

comment:15 Changed 6 years ago by gregorio

  • Action Needed changed from finalize to diagnose

comment:16 Changed 6 years ago by mchua

  • Blocking 7269 removed

(In #7269) Kim says: This has been closed. We need Dari speaking people to fully test all aspects of keyboard, but this specific bug is now closed. Removing blocker so that we can close it.

comment:17 Changed 6 years ago by mstone-xmlrpc

  • Keywords cjbfor9.1.0 added
  • Milestone changed from 8.2.1 to 9.1.0

Pushing out to 9.1.0, per edmcnierney's request.

Note: See TracTickets for help on using tickets.