notify::active behaviour change

[dsd]

In update1, when you launch an activity by clicking an icon, the activity receives a notify::active signal immediately after it has launched. Measure relies on this assumption.

In 8.2, when launching an activity by clicking on the icon, no notify::active signal arrives on launch. However, if you launch from terminal with the sugar-launch command, the signal is indeed generated.

[dsd]

(In #7467) Problems are:

• Porting to numpy needed (trivially easy)
• notify::active behaviour change in #7856

[kimquirk]

tomeu - can you take a look as this is stale but important - possible blocker.

[tomeu]

Bug in the shell:

1. User clicks the icon
2. Shell calls Shell.NotifyLaunch
3. Shell tries to call SetActive(True) on the activity, but it isn't launched yet
4. Shell calls Rainbow.CreateActivity
5. Rainbow launches activity
6. Activity sets up its dbus service, now it is ready to receive the SetActive call

Marco, can you give your opinion on the best way to fix this one?

[marco]

I think set_active should go through homeactivity, which should only propagate it to the dbus service when it's available (it's already tracking the service).

I'm surprised that this bug has been exposed only now.

[thomaswamm]

(In #7771) In 8.2-757, Measure-18 still starts with a grey screen. Same work-around helps: switch to Journal, then back to Measure, then it works.

[mstone]

This issue has an acceptable workaround so it is not a release-blocker. However, since it is an API regression, I would probably accept a clean fix if one appeared in the next week.

[erikos]

set property of activity to active when the service is up

[tomeu]

            if self._service != None:
                self.set_active(True) 

No need to test it here as we are testing inside the method.

        if self._service: 
            self._service.SetActive(state, 

Better use if self._service is None:

[erikos]

Thanks for the comments. Pushed to both branches.

[erikos]

package: sugar-0.82.3-1.olpc3

[erikos]

|TestCase|

verify that launching of activities works as expected

[mstone]

Please record positive test results for me when you generate them.

[cscott]

sugar 0.82.5-1 added to 8.2 repo; should be in build 760 and later. Please test.

[cscott]

http://mock.laptop.org/gitweb/gitweb.cgi?p=repos;a=commitdiff;h=022716da54a06a498962aa978ca335dd43b1fb95

[morgs]

Measure now launches and is functional immediately. Looks good to me.

[mchua]

Measure worksforme in 8.2-760. Closing.

[arjs]

I confirm that on launch the signal is being correctly launched. However when Measure goes into the background, it doesn't release the audio resources until another activity becomes active. Is there a signal supposed to be fired when from the Activity view, one goes to the home view ? If there is code related to this, could someone please point me to that ?

[marco]

I'm not clear if an activity should release audio resources in that case, we discussed this at lenght but I don't think we have a clear policy about it yet. Anyway see visibility-notify-event in activity.py you can do something similar.