Ticket #7939 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Missing stock icons

Reported by: cscott Owned by: cscott
Priority: normal Milestone: 8.2.0 (was Update.2)
Component: gtk-theme Version: Development build as of this date
Keywords: polish:8.2.0 Cc:
Action Needed: test in release Verified: no
Deployments affected: Blocked By:
Blocking: #7413

Description (last modified by cscott) (diff)

The following icons are missing from the sugar theme, and would make "native" GTK applications look much better:

In the 'actions' context:

  • 'edit-clear', 'edit-cut', 'edit-delete', 'edit-select-all', 'edit-find', 'edit-find-replace' -- we've got the other edit- icons, so it looks odd that we've got mismatched icons in the set. 'edit-find' should be similar to 'system-search', which we've already got. 'edit-delete' is present in sugar-artwork but not installed. 'edit-clear' is our favorite "short paintbrush" icon, which should Die.
  • 'go-home' - used in firefox for the home icon.
  • 'window-close' - used in file menu as well as tabs
  • 'document-save-as' - should be consistent with 'document-save'
  • 'process-stop' - should be identical to the 'stop' icon in browse, which is 'media-playback-stop'

In the 'apps' context:

  • 'help-browser' - used for the gtk stock help icon, should be consistent with the icon we use for our help activity.

In the 'places' context:

  • 'folder'. Used for bookmark groups in firefox.

Of these, the two "most visible" icons are those for 'go-home' and 'process-stop', which appear on the firefox toolbar and currently look very out of place.

Attachments

Change History

Changed 6 years ago by cscott

We're also missing "audio-volume-muted", "audio-volume-low", "audio-volume-medium", and "audio-volume-high" in the 'status' context, which are used by totem. See trac #4312 (and its dups #7018, #4078, and #7068).

Changed 6 years ago by cscott

  • blocking 7413 added

Changed 6 years ago by cscott

A first patch is at: http://dev.laptop.org/git?p=users/cscott/sugar-artwork-tmp;a=commitdiff;h=44dd54b316a2fe0d8d89973cbddc74190855e8ec

This doesn't add any new icons, but fixes the makefile to include a few we had present but were not being installed (in particular 'edit-delete').

Changed 6 years ago by cscott

'document-open' in the 'actions' category is also used in places: for example, in the popup menu for the totem media player plugin. This should probably be an alias for 'activity-start'.

Changed 6 years ago by cscott

There's also an upstream bug where icon-naming-utils doesn't install the proper aliases for 'dialog-ok' (the mapping file contains 'dialog-apply' instead, which seems to be a typo, since there's no 'dialog-apply' in http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html ).

So, installing a 'dialog-apply' alias for 'dialog-ok' is also useful for working around this problem.

Patches shortly, for those parts of this bug which don't require me to draw new icons.

Changed 6 years ago by cscott

Ok, ignore the first patch above, it's broken. Below are several patches to address 'edit-delete', 'go-home', 'process-stop', 'application-exit', 'audio-volume-*', 'document-open', and 'dialog-apply'.

Changed 6 years ago by cscott

Changed 6 years ago by cscott

Changed 6 years ago by cscott

Changed 6 years ago by cscott

  • keywords r? added

Changed 6 years ago by cscott

  • keywords polish:8.2.0 added
  • component changed from sugar to gtk-theme

Changed 6 years ago by marco

  • keywords r+ added; r? removed

Changed 6 years ago by marco

  • milestone changed from 9.1.0 to 8.2.0 (was Update.2)

Changed 6 years ago by cscott

  • keywords r+ removed
  • description modified (diff)

Ok, initial patches pushed to git.

Eben, the remaining icons you need to draw are:

In the 'actions' context:

  • 'edit-clear', 'edit-cut', 'edit-select-all', 'edit-find', 'edit-find-replace'
  • 'window-close'
  • 'document-save-as'

In the 'apps' context:

  • 'help-browser'

In the 'places' context:

  • 'folder'. Used for bookmark groups in firefox.

Changed 6 years ago by marco

I had to change it to ln -sf, otherwise reinstallation would fail.

Changed 6 years ago by marco

Looks like you want this in 8.2.0. You will need to push on the sucrose-0.82 branch.

Changed 6 years ago by cscott

Re: ln -sf. I guess you use 'make install' directly; I only use it in a clean build root as part of package creation. Oops. Thanks, marco.

I'll cherry pick this into sucrose-0.82.

Changed 6 years ago by marco

Scott, please change the Action to package as soon as you cherry picked.

Changed 6 years ago by marco

Scott, ping? We will do packages today, so we need this in.

Changed 6 years ago by marco

  • next_action changed from never set to package

Seem to be in already.

Changed 6 years ago by marco

  • owner changed from Eben to cscott
  • next_action changed from package to test in build

Changed 6 years ago by marco

  • next_action changed from test in build to approve for release

Changed 6 years ago by marco

  • next_action changed from approve for release to add to build

Changed 6 years ago by cscott

  • next_action changed from add to build to add to release

Exact package name & version, please.

Changed 6 years ago by cscott

(I split off #8296 for the unfinished part of this bug, so we can close this as soon as the existing patch is verified in the stable build.)

Changed 6 years ago by marco

sugar-artwork-0.82.1-1.fc9

Changed 6 years ago by cscott

  • next_action changed from add to release to test in release

Committed to stable repo; should be in 758 and later; please test.

Changed 6 years ago by cscott

  • status changed from new to closed
  • resolution set to fixed

Changed 6 years ago by frances

please set a testcase for confirmation on the 8.2-760

Note: See TracTickets for help on using tickets.