Ticket #8155 (new enhancement)

Opened 6 years ago

Last modified 6 years ago

Implement hard links in datastore for storing duplicate files

Reported by: morgs Owned by: tomeu
Priority: normal Milestone: Future Release
Component: sugar-datastore Version: not specified
Keywords: Cc: skierpage, sayamindu, edmcnierney
Action Needed: design Verified: no
Deployments affected: Blocked By:
Blocking:

Description

In #6729, skierpage commented:

I noticed that every time I start Browse, visit OLPC Library > images > world maps and click Africa (a PDF), another full copy of the PDF is added to ~olpc/.sugar/default/datastore/store by Read activity 45. If I read this bug correctly, that behavior is a downside of this bug fix.

This could be improved by hard linking identical files with copy-on-write to break the links.

Change History

in reply to: ↑ 1   Changed 6 years ago by skierpage

  Changed 6 years ago by cscott

This bug has been added as an 8.2.1 blocker; next gen journal ideas are out. Is there a reasonable patch to our current 8.2 journal that does this?

  Changed 6 years ago by mstone

  • milestone changed from 9.1.0 to 8.2.1

  Changed 6 years ago by marco

  • cc sayamindu added

I think adding this feature to the current datastore is going to be too risky stability wise. Tomeu rewrite has it, but integrating it would mean to also ship a reimplementation of the usb sticks UI too.

Sayamindu has a patch to browse to open pdf inline, which would work around that case. That's by far the less risky approach, is it enough?

  Changed 6 years ago by edmcnierney

  • keywords 8.2.1:+ added

  Changed 6 years ago by mchua

  • keywords 8.2.1:+ removed

consensus from 8.2.1 meeting: push this ticket (general case) to a later release, unmadindu to make a new ticket with his patch for this specific case which will be in 8.2.1.

  Changed 6 years ago by cjb

  • cc edmcnierney added
  • milestone changed from 8.2.1 to Future Release

Pushing out of the 8.2.1 component.

Note: See TracTickets for help on using tickets.