Colors-3 does not stop / quit

[martin.langhoff]

1 - Start Colors 2 - Draw 3 - Attempt to stop / Quit hitting th stop icon

The activity does not stop. Reading the logs (attached) seems to indicate a bad interaction with the 'take a screenshot at stop time' changes in Sugar.

This is with OS 8.2-759

[rhoward]

This problem also happens with Colors! V4 and OS build 8.2-759.

I tried this a few days ago with Colors! V4 and OS build 8.2-757 and you could stop Colors! successfully.

[rhoward]

Colors! V4 problem is a slight variation. Can close if you save and then use the stop from the menu on the icon in the frame.

[marco]

SugarPreview take_screenshot changed API. We are passing the widget in to be able to get the screen. Doeesn't the default Activity implementation work for Colors?

[martin.langhoff]

The author of Colors indicated that there's a Colors-4 that according to him fixes the problem. It wasn't listed in the Activities page when we undertook our testing (apologies!)

[wadeb]

I'm not sure why I needed to override the screenshot code - I'll look into it and see if the overloaded method can be removed.

Note- Would be nice to have a formal notification system for when these API changes happen.

Cheers, Wade

[marco]

Yeah, sorry. For 0.84 we will create a wiki page where we'll note all the API changes.

There is the question of what is private and what is public in Activity. take_screenshot is clearly public, but I'm not sure about _preview. Since we subclass Activity the usual underscore convention doesn't make it clear. If anyone has thoughts or suggestions about this I'd be glad to hear them.

[tabitha]

Replying to martin.langhoff:

1 - Start Colors 2 - Draw 3 - Attempt to stop / Quit hitting th stop icon The activity does not stop. Reading the logs (attached) seems to indicate a bad interaction with the 'take a screenshot at stop time' changes in Sugar. This is with OS 8.2-759

Confirming this is still happening in Colors-4 testing on same XOs as original bug report

[tomeu]

Replying to marco:

There is the question of what is private and what is public in Activity. take_screenshot is clearly public, but I'm not sure about _preview. Since we subclass Activity the usual underscore convention doesn't make it clear. If anyone has thoughts or suggestions about this I'd be glad to hear them.

I think that anything with an initial underscore needs to be considered as an implementation detail and thus subject to change. Ideally, all identifiers that are part of a public API wouldn't start with an underscore and would have a docstring explaining what the caller can depend on.

[DanKrejsa]

Hi,

Here's a patch that seems to make quitting the Colors! (version 4) activity work on candidate-765. I don't know how this change would affect operation on older XO builds.

---

[dlkrejsa@localhost Colors.activity]$ diff -u colors.py ../colors.py --- colors.py 2008-05-09 03:16:10.000000000 -0700 +++ ../colors.py 2008-09-28 11:48:37.000000000 -0700 @@ -1487,7 +1487,7 @@

def take_screenshot (self):

if self.easelarea and self.easelarea.bin_window:

- self._preview.take_screenshot(self.easelarea.bin_window) + self._preview.take_screenshot(self.easelarea)

def save_thumbnail(self, filename):

pbuf = gtk.gdk.Pixbuf(gtk.gdk.COLORSPACE_RGB, False, 8,

self.width, self.height)

---

A couple of other questions on Colors!

- Is it supposed to play back the saved painting automatically

when an instance starts? Currently it does not.

- After manually going to the watch tab and playing back

the saved painting, then returning to the Paint tab, the first stroke fails to apply any paint. The second stroke succeeds.

[DanKrejsa]

Sorry about the poor wiki formatting of that diff, here it is again (hope this works):

[dlkrejsa@localhost Colors.activity]$ diff -u colors.py ../colors.py 
--- colors.py   2008-05-09 03:16:10.000000000 -0700
+++ ../colors.py        2008-09-28 11:48:37.000000000 -0700
@@ -1487,7 +1487,7 @@
 
     def take_screenshot (self):
         if self.easelarea and self.easelarea.bin_window:
-            self._preview.take_screenshot(self.easelarea.bin_window)
+           self._preview.take_screenshot(self.easelarea)
 
     def save_thumbnail(self, filename):
         pbuf = gtk.gdk.Pixbuf(gtk.gdk.COLORSPACE_RGB, False, 8,
self.width, self.height)

[wadeb]

Applied the patch, thanks! I don't think it will hurt older builds.

[wadeb]

Also, the other bugs you reported should be fixed. They appear to have been caused by changes to Sugar, but I think I've worked around them. Can you try out:

http://www.wadeb.com/Colors!-8.xo

and close this bug if everything looks good? Then I'll release this version to the public.

Thanks for the report,

Wade

[cjl]

changing component to improve discoverability

[martin.langhoff]

This has long been fixed -- apologies, and thanks Wade! :-)