Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8444 closed defect (fixed)

Ignoring handles which are not in roster drop buddies from shared roster

Reported by: gdesmott Owned by: Collabora
Priority: high Milestone: 9.1.0-cancelled
Component: presence-service Version: not specified
Keywords: relnote cjbfor9.1.0 Cc: Collabora, mstone, gregorio
Blocked By: Blocking:
Deployments affected: Action Needed: review
Verified: no

Description

For some reasons, ejabberd doesn't always properly update user's shared roster once we are connected but does send the contact's presence. Problem is, as PS discards presences from contacts who are not in the roster, the Buddy object is not created and so the contact is never displayed on the mesh view.

That's an ejabberd bug but we could workaround it by changing PS to accept contacts which are not in the roster.

Change History (7)

comment:1 Changed 6 years ago by gregorio

  • Cc gregorio added

Hi Guillaume,

Is this shared roster work supposed to be in 8.2.0?

Can you tie it to some specific feature or capability that the user sees?

We need to decide if this is a blocker or not for 8.2.0.

Thanks,

Greg S

comment:2 Changed 6 years ago by gdesmott

Yes, we still use the shared roster in 8.2.0.

Because of an ejabberd shared roster bug, user won't see some connected buddies in his mesh view.

comment:3 Changed 6 years ago by gdesmott

  • Action Needed changed from never set to review

I wrote a workaround in this branch: https://dev.laptop.org/git?p=users/guillaume/presence-service;a=shortlog;h=8444

I should do the job but add some D-Bus round trips. See the comments in the code.

comment:4 Changed 6 years ago by gregorio

  • Keywords relnote added
  • Milestone changed from Not Triaged to 8.2.1
  • Priority changed from normal to high

Is there any workaround (e.g. reboot) or way to know whent his will happen?

I need to figure out how to explain this in the release notes.

Also, is this only going to affect XS connected XOs?

Thanks,

Greg S

comment:5 Changed 6 years ago by gdesmott

According my observations, this bug seems to happen when the user is already connected to the jabber server and then another buddy connects. It works fine when the buddies are connected before us.

comment:6 Changed 6 years ago by gdesmott

  • Resolution set to fixed
  • spec_reviewed set to 0
  • spec_stage set to unknown
  • Status changed from new to closed

This bug was fixed by this commit as part of the Gadget integration work:
https://dev.laptop.org/git?p=projects/presence-service;a=commitdiff;h=ed0b5e3adc45a5127b16e63230edbc918ac54979

comment:7 Changed 6 years ago by mstone-xmlrpc

  • Keywords cjbfor9.1.0 added
  • Milestone changed from 8.2.1 to 9.1.0

Pushing out to 9.1.0, per edmcnierney's request.

Note: See TracTickets for help on using tickets.