Opened 6 years ago

Closed 6 years ago

#8487 closed defect (fixed)

Can't see all items in the Control Panel in Kreyol

Reported by: kimquirk Owned by: kimquirk
Priority: high Milestone: 8.2.0 (was Update.2)
Component: sugar Version: not specified
Keywords: blocks:8.2.0 r+ Cc: gregorio, andresambrois, bastienguerry@…
Blocked By: Blocking:
Deployments affected: Action Needed: test in release
Verified: no

Description

Build 8.2-760 on a Kreyol keyboard

I went to the control panel and the translated words are long enough that all the items don't fit in the window of the control panel. Specifically you can't see 'translation' item to choose a language.

There is no way to scroll horizontally or vertically to get to that item. I will not write up individual bugs for each language that I find this problem... but we can assume there will be more.

Test case: http://wiki.laptop.org/go/Tests/Keyboard_mappings

Attachments (2)

8487.patch (1.7 KB) - added by andresambrois 6 years ago.
cp_haiti.png (39.1 KB) - added by erikos 6 years ago.
haiti in sugar-jhbuild

Download all attachments as: .zip

Change History (22)

comment:1 Changed 6 years ago by cjb

Marco, Kim, propose a milestone for this?

comment:2 Changed 6 years ago by kimquirk

  • Cc gregorio added
  • Keywords blocks?:8.2.0 added
  • Milestone changed from Not Triaged to 8.2.0 (was Update.2)
  • Owner changed from marco to erikos

Changing ownership for simon to help figure out the work effort. Also added 'blocks?' so we can re-evaluate the blockerness based on what countries are depending on 8.2. Probably this will be moved to 8.2.1.

comment:3 Changed 6 years ago by gregorio

  • Keywords blocks:8.2.0 added; blocks?:8.2.0 removed

Hi Guys,

Haiti plans to use 8.2 so we must fix this.

Thanks,

Greg S

comment:4 Changed 6 years ago by erikos

I already filed one about that issue #8148

Changed 6 years ago by andresambrois

comment:5 Changed 6 years ago by andresambrois

  • Keywords r? added

This patch adds a gtk.ScrolledWindow to the control panel, it may not be a pretty fix, but it works and its simple.

comment:6 Changed 6 years ago by erikos

  • Keywords r- added; r? removed

I don't think we want a scrolled window here - since we have enough space. Adding the xoptions=gtk.SHRINK option when attaching items to the table does solve the issues. But I am not sure yet this is the best fix neither.

comment:7 Changed 6 years ago by andresambrois

  • Cc andresambrois added

Changed 6 years ago by erikos

haiti in sugar-jhbuild

comment:8 follow-up: Changed 6 years ago by gregorio

  • Cc bastienguerry@… added

Hi Guys,

I wouldn't worry about the aesthetics at this stage. We can revisit this in 8.2.1 if needed.

Which solution has the list risk to damage or cause problems elsewhere?

Which is the easiest to implement and test?

Which ever solution wins on those two counts sounds like the right strategy to get this closed without delaying the release.

Thanks,

Greg S

comment:9 in reply to: ↑ 8 Changed 6 years ago by marco

There are two possible short time solutions here:

  • Reimplement the icon view using hippo.
  • Add a scrollbar to the view, which will be visible for languages that overflow.

The hippo solution would be good enough until post 9.1 (at least).

Replying to gregorio:

Which solution has the list risk to damage or cause problems elsewhere?

Hippo is only slightly more risky I think (the code changes would be larger but easy to test).

Which is the easiest to implement and test?

Scrollbar should be easier to implement (I can't say for sure until we tried it though). Test effort should be equivalent.

comment:10 Changed 6 years ago by cscott

Another option is to punt this to the translators: ask the translators to please provide shorter strings, either by using abbreviations or by choosing an alternate wording.

comment:11 Changed 6 years ago by erikos

  • Action Needed changed from never set to package
  • Keywords r+ added; r- removed

Actually we pushed the scrolled window for now (thanks andres) and do better laying out the icons for 0.82.1 (using hippo).

comment:12 Changed 6 years ago by gregorio

Sounds good!

Call it done for now.

Greg S

comment:13 Changed 6 years ago by marco

  • Action Needed changed from package to test in build

comment:14 Changed 6 years ago by erikos

  • Action Needed changed from test in build to approve for release

package: sugar-0.82.8-1.olpc3

|TestCase|

Open the control panel and switch to using the Haiti (kreyol). Open the control panel again. There should be a horizontal scrollbar that let's you scroll to all the items

comment:15 Changed 6 years ago by mstone

  • Action Needed changed from approve for release to add to release

Approved; thanks for the clear message!

comment:17 Changed 6 years ago by cscott

  • Summary changed from Can't see all items in the Control Panel to Can't see all items in the Control Panel in Kreyol

comment:18 Changed 6 years ago by cscott

  • Action Needed changed from add to release to test in release

Please test build 761 resulting from build-repo commit b7c11be9.

comment:19 Changed 6 years ago by mchua

  • Owner changed from erikos to kimquirk

assigning to kimquirk to test as per kim's request to test i18n bugs for this round.

comment:20 Changed 6 years ago by mchua

  • Resolution set to fixed
  • Status changed from new to closed

Verified in 766, Kreyol keyboard machine in Kim's office. It's not super-pretty to have to scroll so far for this, but you can see/access all options. Closing.

Note: See TracTickets for help on using tickets.