8.2-760 olpc-update from 656 uninstalls core Activities, doubles sessions in Journal when reinstalled

[mchua]

Two strange things occurred while running the data integrity test (to see if pre-upgrade Activity sessions are still usable post-upgrade) for a build 656 to a release-candidate 8.2-760 upgrade.

Immediately after upgrading to 8.2-760 via olpc-update, the core Activities being tested (Browse, Write, TurtleArt, Record, EToys) were found to be no longer present in Sugar (strange thing #1).

Pre-upgrade sessions from these Activities were still in the Journal under their correct names with a generic "file" icon, and attempting to resume them failed (as expected, since the Activity that should be used to open them was not present), with the exception of the Record session, which displayed and was opened as a simple image.

When these Activities were reinstalled (via the Update option in the Control Panel), the Journal still displayed their pre-upgrade sessions with a generic "file" icon. Attempting to resume these pre-upgrade sessions now succeeded, with the correct Activity launching.

After launching the pre-upgrade sessions successfully with the reinstalled Activity, the Journal displayed two sessions for each pre-upgrade session (strange thing #2): one with the generic "file" icon and a timestamp dating to the last time it was resumed before the upgrade, and one with the correct Activity icon and a correct/recent timestamp from the resume that had just been carried out.

Again, the exception here was the pre-upgrade Record session, which still displayed and launched as a simple image. (Record sessions started after Record was reinstalled save/resume in the Journal as Record sessions.)

More investigation is needed to tell whether this is a 656 to 760 olpc-update issue, an Activities updating issue, something that can happen occasionally during upgrades from various builds, or something else. Will try to reproduce.

[cscott]

This seems like the expected behavior to me. Didn't 760 prompt you to (re)install your activities on first boot?

[mchua]

The bug isn't that certain Activities didn't install during the upgrade (it did prompt me to reinstall Activities on first boot, but didn't download the core ones on the first pass - it did the second time I ran it).

The bug I think exists (trying to reproduce now) is the doubling of the Journal entries for saved sessions that initially didn't have Activities to open them. After installing the correct Activity and then using that Activity to resume an old pre-update session, I'd expect the resumed session to appear in the Journal once with a timestamp reflecting that it had just been used, instead of twice (once with a pre-update timestamp, once with a timestamp reflecting that it had just been used).

In other words, in your Journal before resuming the Activity...

* [generic-file-icon] my.savedsession.name ---- 4 hours ago

In your Journal after resuming the Activity, what *should* happen, imo...

* [Activity-icon] my.savedsession.name ---- Now

Instead, what you get...

* [Activity-icon] my.savedsession.name ---- Now * [generic-file-icon] my.savedsession.name ---- 4 hours ago

[mstone-xmlrpc]

changed by irc user m_stone:

We're in disagreement about how many people will update to 8.2.0; hence about how significant this bug is. For the time-being, I'm going to argue that we can fix it in 8.2.1 if it becomes a real problem.

[mstone-xmlrpc]

changed by irc user cjb:

(FWIW, I agree with making this 8.2.1 even while disagreeing about how many people will upgrade.)

[mstone-xmlrpc]

Pushing out to 9.1.0, per edmcnierney's request.