Opened 6 years ago

Closed 6 years ago

#8554 closed defect (fixed)

Indicate connected AP in Neighborhood view.

Reported by: Eben Owned by: cscott
Priority: normal Milestone: 8.2.0 (was Update.2)
Component: sugar Version: not specified
Keywords: relnote 8.2-762:+ Cc: mtd, Eben, isforinsects
Blocked By: Blocking:
Deployments affected: Action Needed: finalize
Verified: no

Description

Many testers of the latest design have been confused by the lack or indication of the connected AP in the neighborhood. While the new design adds the network node to the Frame, accessible from anywhere, the old design had a white stroke on the connected AP.

While the white stroke was not a good solution, both because it strips the "identity" of the AP and because it just wasn't that noticeable, it's a good idea to have a differentiator here.

Attachments (2)

tmpIBt4g6.png (25.6 KB) - added by mtd 6 years ago.
screenshot with cscott's sugar and sugar-artwork rpms showing odd fill in AP icons
0002-Change-mesh-icon-after-we-ve-connected.patch (3.5 KB) - added by cscott 6 years ago.

Download all attachments as: .zip

Change History (19)

comment:1 Changed 6 years ago by mtd

  • Action Needed changed from code to review
  • Cc mtd added; 8.2.0:? removed
  • Keywords r? 8.2.0? added

comment:2 Changed 6 years ago by mtd

  • Action Needed changed from review to testcase
  • Keywords r+ added; r? removed

r+ -- looks cool.

But there are some artwork patches I think we need too (for the icons) so I'll wait to push to git until those are available, though I could just be being jumpy here and anyone more informed is welcome to act on the r+ (of course).

comment:3 Changed 6 years ago by cscott

patched rpms for sugar and sugar-artwork at http://dev.laptop.org/~cscott/fer-eben/ now.

I need someone to actually test these, though: I forgot to bring an XO home with me. =(

Test that the icon changes when you connect to an access point, to an (o) icon, and that both the mesh view and the icon in the frame change appropriately. Check that the icon stays correct as the strength of the network changes, if you can. Finally, since the emblem location was part of the new icons Eben created, double check that the 'favorites star' stays in place and doesn't wander as the icon traverses the 'not connected', 'connecting', and 'connected' states.

comment:4 Changed 6 years ago by cscott

Eben's patch should be pulled from master to sucrose-0.82 if it passes testing.

comment:5 Changed 6 years ago by mstone

  • Action Needed changed from testcase to package

I tested these rpms and was very satisfied with the results.

comment:6 Changed 6 years ago by mtd

The fill looks odd on the AP icons in the Neighborhood view...see attached screenshot.

Is anyone else seeing this?

Changed 6 years ago by mtd

screenshot with cscott's sugar and sugar-artwork rpms showing odd fill in AP icons

comment:7 Changed 6 years ago by cscott

Hm, those should have been the *unaffected* icons. I'll take a look.

comment:8 Changed 6 years ago by cscott

  • Cc Eben added

It seems to be deliberate on Eben's part? I can edit the files to remove the extra fill; Eben, which do you prefer?

comment:9 Changed 6 years ago by cscott

from irc:

(10:06:16 AM) C. Scott Ananian: eben: what about the filled center in the new ap icons?
(10:06:21 AM) C. Scott Ananian: eben: was that intentional?
(10:06:34 AM) eben: c_scott: Pentagram and I both like them.  We've been using them in mockups for a while.
(10:06:56 AM) C. Scott Ananian: eben: ok, i guess #8554 is ready to go then.

comment:10 Changed 6 years ago by cscott

Ok, committed to master and sucrose-0.82. I'm going to attach the patch which changes the icon shape for mesh icons; we're not using this right now, but if Eben ever decides he wants mesh halos, the patch will be right here.

comment:11 Changed 6 years ago by marco

  • Action Needed changed from package to test in build

comment:12 Changed 6 years ago by erikos

  • Action Needed changed from test in build to approve for release

I see the icon :)

comment:14 Changed 6 years ago by mstone

  • Action Needed changed from approve for release to add to release

Very nice work.

comment:15 Changed 6 years ago by cscott

  • Action Needed changed from add to release to test in release

Please test build 761 resulting from build-repo commit b7c11be9.

comment:16 Changed 6 years ago by mstone-xmlrpc

  • Action Needed changed from test in release to finalize
  • Cc isforinsects added
  • Keywords relnote 8.2-762:+ added; r+ 8.2.0? removed

changed by irc user m_stone:

We're tentatively satisfied that this works in 8.2-762; relnotes needed. (and maybe an update to the Help activity?)

comment:17 Changed 6 years ago by gregorio

  • Resolution set to fixed
  • Status changed from new to closed

Added to resolved section of the release notes. GS

Note: See TracTickets for help on using tickets.