Bug in WPA key dialog prevents certain passwords from being accepted

[Eben]

I've been trying to connect to my access point with 763, but when I press enter (or click the OK button) nothing happens. Looking at the logs, I see two strange things. It reports:

(s, 0) = commands.getstatusoutput(command)
if s != 0:
    raise RuntimeError("Error hashing passphrase: %s" % o)

global RuntimeError = undefined
o = ''

So, first of all I have no idea why RuntimeError is undefined. That aside, the real problem is that the passphrase string passed to /usr/bin/wpa_passphrase isn't properly escaped or quoted (my passphrase includes a single quote), which is causing it to crap out and return nothing.

I tried running the script directly with my passphrase properly quoted and/or escaped and it ran fine.

It seems this is easy to fix, but a big win to fix for G1G1.

[cscott]

Patch fixing the problem.

[cscott]

The use of commands.getstatusoutput is very sketchy. In the attached patch, I've replaced this with subprocess.Popen, which is the preferred way to invoke other programs these days.

[cscott]

(Reviewers: the import should be moved to the top of the file, and I'll do that before I commit if the patch is approved, but I was trying to make this easy for Eben to type in my hand to get his machine on the network.)

[Eben]

I just "patched" my machine by hand, and succeeded in connecting to my network without a problem. Thanks for the lightning fast fix, Scott!

[mstone]

I would be willing to consider accepting this fix as WPA polish which is certainly important to us pending packaging and acceptance in joyride. It remains to be seen whether we will make any more 8.2.0 builds.

[mstone]

Greg and I believe that this is not a blocker (though internet connectivity is really important to us.)

[cscott]

For fun, try using

'; /bin/rm -rf '~

as your WPA password!

Obligatory xkcd: http://xkcd.com/327/

[cscott]

Pushed to sucrose-0.82 and master.

[marco]

Code:

http://dev.laptop.org/git?p=sugar;a=commit;h=d109fcc71339c410aacb0736eb87c9ab4986fe1d

Package:

sugar-0.82.9-1.olpc3

[cscott]

In joyride-2485 and later. Eben, please retest? Michael, consider for next stable build.

[cscott]

Packages added to stable repository in commit 59fd5419 for build 764. Please confirm the package versions are correct and test in stable build 764 or later.

[dsd]

Looks like this was correctly fixed for 8.2, and for later releases all this stuff changed anyway.