Opened 6 years ago

Closed 4 years ago

#8733 closed defect (fixed)

no feedback when you Start a journal entry that no activity can open

Reported by: skierpage Owned by: erikos
Priority: normal Milestone: 10.1.3
Component: journal-activity Version: 1.5/1.0 Software Build os852 aka 10.1.2
Keywords: Cc:
Blocked By: Blocking:
Deployments affected: Action Needed: no action
Verified: no

Description

I upgraded to candidate-765 from build 650 and forgot I had no activities. I copied a PDF and .odt file from USB flash drive to the journal. I can hover over the icon and a menu appears with Start; and I can click (>) for more details then click the [>] Start menu item. But these do nothing.

The JournalActivity log contains "WARNING: root: No activity can open this object, application/pdf" or application/vnd.oasis.... I think the Journal should show some kind of warning, or better it should disable the Start menu item and replace its hover dropdown with "Start (no installed activity can open this)".

Change History (11)

comment:1 Changed 6 years ago by gregorio

  • Milestone changed from Not Triaged to 8.2.1

comment:2 Changed 6 years ago by mstone-xmlrpc

  • Keywords cjbfor9.1.0 added
  • Milestone changed from 8.2.1 to 9.1.0

Pushing out to 9.1.0, per edmcnierney's request.

comment:3 Changed 6 years ago by skierpage

This is still the case in staging-27 (an 8.2.1 pre-release), e.g. stick in a USB with a .mp3 file on it.

comment:4 Changed 6 years ago by skierpage

I added a copy of this bug to Sugarlabs' trac, http://dev.sugarlabs.org/ticket/328 , hope that's OK.

comment:5 follow-up: Changed 4 years ago by Quozl

  • Action Needed changed from never set to review
  • Milestone changed from 9.1.0-cancelled to 10.1.3
  • Version changed from not specified to 1.5/1.0 Software Build os852 aka 10.1.2

http://patchwork.sugarlabs.org/patch/324/ patch proposed by Mukal Gupta on SL328.

comment:6 in reply to: ↑ 5 ; follow-up: Changed 4 years ago by erikos

Replying to Quozl:

http://patchwork.sugarlabs.org/patch/324/ patch proposed by Mukal Gupta on SL328.

Hmm, not sure it can go in 0.84 like that. It adds a new string which I find problematic. Has it been accepted upstream?

comment:7 in reply to: ↑ 6 Changed 4 years ago by Quozl

  • Keywords cjbfor9.1.0 removed

Replying to erikos:

Replying to Quozl:

http://patchwork.sugarlabs.org/patch/324/ patch proposed by Mukal Gupta on SL328.

Hmm, not sure it can go in 0.84 like that.

That's old. Was a heads-up. See SL328 for what was actually committed to HEAD.

It adds a new string which I find problematic.

The committed patch does not add a new string, it re-uses "No activity to start entry".

Has it been accepted upstream?

A patch 3543be2 has been committed. See SL328.
It also applies fine to sucrose-0.84.

comment:8 Changed 4 years ago by erikos

  • Owner changed from tomeu to erikos

comment:9 Changed 4 years ago by erikos

  • Action Needed changed from review to add to build

comment:10 Changed 4 years ago by erikos

  • Action Needed changed from add to build to test in build

In os351.

comment:11 Changed 4 years ago by greenfeld

  • Action Needed changed from test in build to no action
  • Resolution set to fixed
  • Status changed from new to closed

Tested in 10.1.3 os351 that "No activity to start entry" appears in grayed-out text in the journal for RPM files (which Sugar does not know about) instead of the "Start" menu choice. Verified this both with an RPM on a USB stick as well as copied to the main Journal. Switched the language in Sugar to Spanish to verify that the text string has been translated to at least one other language.

Used copy-to-journal to copy a text file to a Sugar entry with a bogus mime type and verified that Sugar properly no longer knew what to do with this file as well.

Note: See TracTickets for help on using tickets.