Opened 6 years ago

Closed 3 years ago

#8942 closed defect (wontfix)

Need to update Xorg.conf file for Synaptics touchpad

Reported by: dsaxena Owned by: mstone
Priority: high Milestone: 9.1.0-cancelled
Component: x window system Version: not specified
Keywords: 9.1.0:+ Cc: wad, dsaxena, cscott, marco, sayamindu
Blocked By: Blocking: #9101
Deployments affected: Action Needed: package
Verified: no

Description

As per my comment in #8901, we need our Xorg.conf file to load and use the Synaptics driver on laptops with the new touchpad. I'll generate that but I'm not sure how we go about integrating it into the distro.

Attachments (2)

xorg.conf.diff (759 bytes) - added by dsaxena 6 years ago.
xorg.conf diff
olpc-utils-0.89-1.olpc3.1.src.rpm (49.5 KB) - added by mstone 6 years ago.
SRPM with dsaxena's patch applied. (koji scratch build)

Download all attachments as: .zip

Change History (16)

comment:1 Changed 6 years ago by dsaxena

  • Cc dsaxena added; cscott removed
  • Owner changed from dsaxena to cscott

Following patch to xorg.conf allows us to work with both new and old TP. We don't load evdev by default and give priority to the Synaptics device so that it is claimed by the synaptics driver before the evdev driver comes up.

--- xorg-old.conf       2008-11-06 19:16:23.000000000 +0000
+++ xorg.conf   2008-11-06 19:17:45.000000000 +0000
@@ -3,6 +3,7 @@
 Section "ServerLayout"
        Identifier     "Default Layout"
        Screen      0  "Screen0" 0 0
+       InputDevice     "Synaptics" "AlwaysCore"
 EndSection

 #Section "ServerFlags"
@@ -18,7 +19,6 @@
                Option "omit Extended-Visual-Information"
        EndSubSection
        Load  "freetype"
-       Load  "evdev"
        # Load "record" # Mostly a debugging tool
 EndSection

@@ -69,6 +69,13 @@
 EndSection

 Section "InputDevice"
+        Identifier     "Synaptics"
+        Driver         "synaptics"
+       Option          "Protocol" "auto-dev"
+       Option          "FingerHigh" "30"
+       Option          "FingerLow" "25"
+EndSection
+Section "InputDevice"
         Identifier "ATKbd"
         Driver     "evdev"

We may have to tweak some more synaptics-specific options in the config as we play with it more, but this will be good for now.

Assigning to Scott to package into Joyride.

Changed 6 years ago by dsaxena

xorg.conf diff

comment:2 Changed 6 years ago by dsaxena

  • Action Needed changed from code to package

comment:3 Changed 6 years ago by cscott

  • Owner changed from cscott to mstone

Reassigning to mstone to spread the love around.

comment:4 Changed 6 years ago by mstone

  • Cc cscott marco sayamindu added
  • Status changed from new to assigned

Here's my first attempt at building this patch into olpc-utils; unfortunately, the patch provided by dsaxena doesn't apply cleanly. I don't expect any problems fixing that up tomorrow.

_However_, this patch changes a fundamental aspect of system -- namely, how evdev is loaded -- and will therefore require either significant retesting or love from someone who actually understands X. (Which I don't.)

Thoughts?

P.S. - Marco has some conflicting patches in the main OLPC-3 branch of olpc-utils in koji. Marco -- can you comment on your patches?

comment:5 Changed 6 years ago by mstone

  • Milestone set to 8.2.1

comment:6 Changed 6 years ago by edmcnierney

This bug was not on the previous list of 8.2.1 tickets. Why was it set to 8.2.1? I'm fine with the need to provide complete support for the new touchpads; I'm mainly checking in on the process of deciding that something merits an 8.2.1 milestone.

comment:7 follow-up: Changed 6 years ago by dsaxena

I do not think this should be 8.2.1 but joyride/9.1. This change is needed only if we want to fully support the Synaptics feature set such as finger scroll.

comment:8 Changed 6 years ago by mstone

Scott added this ticket to the ECO page yesterday evening. Perhaps he can explain why he thinks it should be included in 8.2.1?

Changed 6 years ago by mstone

SRPM with dsaxena's patch applied. (koji scratch build)

comment:9 in reply to: ↑ 7 Changed 6 years ago by dsaxena

Replying to dsaxena:

I do not think this should be 8.2.1 but joyride/9.1. This change is needed only if we want to fully support the Synaptics feature set such as finger scroll.

Additionally, supporting this feature set also requires a kernel config change which means a new kernel, and we do not want to do that for 8.2.1 AFAIK.

comment:10 Changed 6 years ago by dsaxena

  • Blocking 9101 added

comment:11 follow-up: Changed 6 years ago by edmcnierney

  • Keywords 8.2.1:+ added

comment:12 in reply to: ↑ 11 Changed 6 years ago by dsaxena

Replying to edmcnierney:

keywords 8.2.1:+ added

As mentioned in comment:7 and comment:8, I think this change is not needed for 8.2.1. Unless we resolve all the issues blocking #9101 so we can use the full synaptics capabilities, we don't need this.

comment:13 Changed 6 years ago by mchua

  • Keywords 9.1.0:+ added; 8.2.1:+ removed
  • Milestone changed from 8.2.1 to 9.1.0

comment:14 Changed 3 years ago by dsd

  • Resolution set to wontfix
  • Status changed from assigned to closed

Per the discussion in #10417 we have found that enabling the synaptics Absolute mode and using the userspace driver is not what we want, due to the change of behaviour where it floods us with a constant stream of packets (even if the EC could cope, this is undesirable for us). Also, we use kbdshim anyway now, so no Xorg conf changes or Xorg userspace driver would be needed. We have also got the synaptics kernel driver upstream into a state where we can disable tap-to-click.

Note: See TracTickets for help on using tickets.