Ticket #9126 (assigned enhancement)

Opened 6 years ago

Last modified 6 years ago

US English keyboard generates "wrong" accent character

Reported by: wad Owned by: sayamindu
Priority: high Milestone: 8.2.1
Component: keyboards Version: not specified
Keywords: r+ Cc: edmcnierney, sayamindu
Action Needed: finalize Verified: no
Deployments affected: Blocked By:
Blocking:

Description

A Spanish speaking country is looking to use US English keyboards for some of their laptops, and want the experience to be similar to the Spanish keyboard. In particular, the key sequence which invokes an accented vowel is different between the two keyboards: With an international keyboard: vocal + alt gr/4 With a spanish keyboard: accent + vocal

(Quoting Sayamindu:) It looks like the accent in the US English keyboard is a combining acute accent (U+0301), while the one on the Spanish layout is a dead acute, which means if you press the accent character and then, say, e, you will get U+00E8 (ie, a character with a distinct Unicode codepoint). Accent + e on the US English will, on the other hand generate U+0065 LATIN SMALL LETTER E U+0300 COMBINING GRAVE ACCENT

The manufacturing data on these laptops will have the LO field changed to a value of es_MX.UTF-8, which is used on other Spanish laptops.

The packages that need to change are: a) xkeyboard-config b) olpc-utils (to do special casing for machines with US(Intl) keyboard but es_MX.UTF-8 locale)

Attachments

olpc-utils-pe_us_kbd.patch (0.8 kB) - added by sayamindu 6 years ago.
olpc-xkeyboard-config-es.patch (1.0 kB) - added by sayamindu 6 years ago.

Change History

  Changed 6 years ago by sayamindu

  • status changed from new to assigned

  Changed 6 years ago by sayamindu

  • cc edmcnierney added

Just noticed that the milestone is set to 8.2.1. Are we targeting that release ?

  Changed 6 years ago by sayamindu

  • cc sayamindu added
  • owner changed from sayamindu to mstone
  • status changed from assigned to new

Michael, please review the attached patch for olpc-utils. This one is already in joyride without causing any major breakage :-). I'll push the other patch to xkeyboard config in joyride by tonight.

Changed 6 years ago by sayamindu

  Changed 6 years ago by mstone

  • keywords r+ added
  • owner changed from mstone to sayamindu
  • next_action changed from code to package

The patch looks fine to me. Please push and build.

  Changed 6 years ago by sayamindu

  • status changed from new to assigned
  • next_action changed from package to test in build

RPM builds for both olpc-utils and xkeyboard-config are in /home/sayamindu/public_rpms/staging The next staging build should have the relevant RPMs in them.

I'll push the changes into Koji as soon as I test a staging build.

  Changed 6 years ago by sayamindu

| Test Case |

Change the following tags in mfg-data to

KM: olpc
KL: us
KV: olpc
LO: es_MX.UTF-8

Update the laptop with the relevant build

In the Sugar MeshView search bar Press AltGr + 3 followed by an 'e'

Expected Result:

You get the character è

  Changed 6 years ago by sayamindu

It looks the earlier staging build (os5) did not work for this (some more work needed to be done so that XKB actually allowed olpc2 variant for Spanish). I have pushed the newer rpms in /home/sayamindu/public_rpms/staging

xkeyboard-config-1.3-6.olpc3.noarch.rpm
xkeyboard-config-1.3-6.olpc3.src.rpm

This should work. I'll attach the updated patch against xkeyboard-config as well.

Changed 6 years ago by sayamindu

  Changed 6 years ago by cscott

New version appears to be in staging-6. Please test.

  Changed 6 years ago by sayamindu

  • next_action changed from test in build to approve for release

Works for me in staging-6.

Request for approval of the following packages:

xkeyboard-config-1.3-6
olpc-utils.i386 0:0.89-5

Do you want me to push the changes in Koji and start a build, or will the rpms in my public_rpms do ?

  Changed 6 years ago by cjb

  • next_action changed from approve for release to add to release

Hi Sayamindu,

Approved; please use koji, so that these changes persist to future releases.

follow-up: ↓ 12   Changed 6 years ago by dsd

Built at http://koji.fedoraproject.org/koji/taskinfo?taskID=1086090 Sayamindu, please put these koji-built RPMs in your staging public_rpms (replacing the originals)

in reply to: ↑ 11   Changed 6 years ago by sayamindu

Replying to dsd:

Built at http://koji.fedoraproject.org/koji/taskinfo?taskID=1086090 Sayamindu, please put these koji-built RPMs in your staging public_rpms (replacing the originals)

Done. This needs to be done for xkeyboard-config as well. Waiting for commit access to CVS... (I'm sure I had commit access before)

  Changed 6 years ago by dsd

  Changed 6 years ago by sayamindu

  • next_action changed from add to release to finalize

Uploaded.

  Changed 6 years ago by cjb

  • next_action changed from finalize to test in release

Tested, too? In which build?

  Changed 6 years ago by sayamindu

Oh, sorry. Works in staging-15.

  Changed 6 years ago by dsd

  • next_action changed from test in release to finalize
Note: See TracTickets for help on using tickets.