Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#9248 closed defect (fixed)

no sanitization of sound settings

Reported by: dsd Owned by: cjb
Priority: normal Milestone: 8.2.2
Component: olpc-utils Version: not specified
Keywords: ml8.2.3 Cc: martin.langhoff
Blocked By: Blocking:
Deployments affected: Paraguay Action Needed: never set
Verified: no

Description

Activities can modify sound mixer levels, and these are saved on shutdown because /etc/init.d/halt calls salsa.

We have seen a number of cases where laptops have broken sound because PCM is muted and at 0 volume.

In Paraguay we will work around this by copying the stock asound state to a non-standard filename and hacking olpc-configure to restore from that special file during boot (if an activity screws up sound, then a reboot will fix it).

Change History (8)

comment:1 Changed 6 years ago by cjb

  • Owner changed from mstone to cjb

In Paraguay we will work around this by copying the stock asound state to a non-standard filename and hacking olpc-configure to restore from that special file during boot (if an activity screws up sound, then a reboot will fix it).

Maybe we should just take this patch for everyone, instead?

comment:2 Changed 5 years ago by martin.langhoff

  • Cc martin.langhoff added
  • Keywords ml8.2.3 added

comment:3 Changed 5 years ago by martin.langhoff

  • Milestone changed from Not Triaged to 8.2.2

comment:4 Changed 5 years ago by martin.langhoff

Fix is in olpc-utils 0.89.1

comment:5 Changed 5 years ago by cjb

Are these going to olpc-utils master? This is a bad time to be committing unreviewed changes to the 1.5 build..

comment:6 Changed 5 years ago by martin.langhoff

Hi cjb,

  • The 0.89.1 rpm is going to the 8.2.2 builds I am preparing.
  • A version of this patch has gone into master, together with other patches. But git master is a long way from a 1.5 build: I haven't been tagged a release or rolled them into an rpm. I have left that for Daniel.

comment:7 Changed 5 years ago by martin.langhoff

  • Component changed from distro to olpc-utils
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in olpc-utils-0.89.1

comment:8 Changed 5 years ago by martin.langhoff

Maybe we should split 8.2.2 vs F11 tasks...

Note: See TracTickets for help on using tickets.