Opened 5 years ago

Closed 5 years ago

#9899 closed defect (fixed)

Method for disabling wireless while running

Reported by: cjb Owned by: cjb
Priority: high Milestone: 1.5-software-later
Component: distro Version: Development build as of this date
Keywords: Cc: sayamindu
Blocked By: Blocking:
Deployments affected: Action Needed: test in build
Verified: no

Description

dsaxena's rfkill patches achieve this. This ticket coordinates merging the kernel patches and hooking them into the Network control panel.

Attachments (4)

checkbox_using_rfkill.patch (3.3 KB) - added by pgf 5 years ago.
patch to make Radio checkbox invoke rfkill
no_more_extreme_power.patch (6.0 KB) - added by pgf 5 years ago.
patch to remove the "extreme" power management checkbox
combined_sugar_rfkill.patch (9.9 KB) - added by pgf 5 years ago.
revised/combined patch. obsoletes two previous patches.
no_re.patch (992 bytes) - added by pgf 5 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 5 years ago by pgf

several things need to happen:

1) fedora package "rfkill" needs to be added to the build -- it provides /sbin/rfkill.

2) a udev rule should give group 'dialout' ownership of /dev/rfkill. (we use group 'uucp' for granting access to serial ports, so 'dialout' is unused.)

3) user olpc should become a member of group dialout.

4) the control panel should use rfkill command to unblock/block wifi when the control panel box is checked/unchecked. when unchecked (radio disabled), a flag file (/home/olpc/.rfkill_block_wifi) will be created, and removed when the radio is enabled.

5) /etc/init.d/olpc-configure needs to check the flag file on boot, and rfkill block the interface if the file is present.

comment:2 Changed 5 years ago by pgf

cjb has arranged for 3) to happen on next build. cjb -- can you do 1) as well?

i'm testing patches for sugar for 4), and for olpc-utils for 2) and 5).

Changed 5 years ago by pgf

patch to make Radio checkbox invoke rfkill

Changed 5 years ago by pgf

patch to remove the "extreme" power management checkbox

comment:3 Changed 5 years ago by pgf

  • Cc sayamindu added

sayamindu -- could you review and commit the two attached patches to 0.84?

one patch takes care of 4), the other removes the extreme power management checkbox from the power control panel, because it is currently non-functional, and the rfkill stuff makes it redundant.

Changed 5 years ago by pgf

revised/combined patch. obsoletes two previous patches.

comment:4 Changed 5 years ago by pgf

saymindu -- please apply combined_sugar_rfkill.patch instead of the previous patches. this catches a couple of error cases that those didn't catch.

thanks.

Changed 5 years ago by pgf

comment:5 Changed 5 years ago by pgf

sayamindu -- apply (after review :-) no_re.patch to get rid of the import of re.

comment:6 Changed 5 years ago by sayamindu

  • Action Needed changed from design to package

Thanks!!
Patch applied to sugar - I would make a release within the next few hours.

comment:7 Changed 5 years ago by sayamindu

  • Action Needed changed from package to add to build

New RPMs are in my public_rpms - should be picked up by the next build.

comment:8 Changed 5 years ago by sayamindu

There was a small error in the patch - fixed it and RPMs for 0.84.14 are in my public_rpms.

comment:9 Changed 5 years ago by Quozl

/dev/rfkill needs dialout group.

comment:10 Changed 5 years ago by cjb

  • Action Needed changed from add to build to test in build

Already queued for the next build.

comment:11 Changed 5 years ago by Quozl

Tested, /dev/rfkill is not yet writable by Sugar in os117. Waiting for a build after os117 before retesting.

comment:12 Changed 5 years ago by Quozl

  • Resolution set to fixed
  • Status changed from new to closed

Tested on os118, works now. Closing.

Note: See TracTickets for help on using tickets.